Skip to content

[skip-changelog] Refactoring of the testsuite environment #1852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 27, 2022

Conversation

MatteoPologruto
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?

Infrastructure Enhancement

What is the new behavior?

New functions have been added to setup the arduino-cli environment in order to perform integration tests. CreateArduinoCLIWithEnvironment now performs the minimum amount of actions to build the default test environment.
Existing integration tests have been modified to use the new setup.

Does this PR introduce a breaking change, and is titled accordingly?

No


See how to contribute

@MatteoPologruto MatteoPologruto added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Aug 26, 2022
@MatteoPologruto MatteoPologruto self-assigned this Aug 26, 2022
@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #1852 (d39a09d) into master (63f1e18) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1852      +/-   ##
==========================================
+ Coverage   36.33%   36.39%   +0.05%     
==========================================
  Files         231      231              
  Lines       19555    19572      +17     
==========================================
+ Hits         7106     7123      +17     
  Misses      11620    11620              
  Partials      829      829              
Flag Coverage Δ
unit 36.39% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/integrationtest/arduino-cli.go 82.10% <100.00%> (+1.75%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@MatteoPologruto MatteoPologruto marked this pull request as ready for review August 26, 2022 15:49
@cmaglie cmaglie merged commit aa41d72 into master Aug 27, 2022
@cmaglie cmaglie deleted the testsuite-refactor branch August 27, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants